Use RMM adaptor constructor rather than factory function #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
non-breaking
3 tasks
|
Duplicate of #4557. I merged the change to add |
|
My bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RMM will be deprecating and removing its adaptor factory functions (
make_*_adaptor). These were needed prior to C++17 due to the lack of CTAD, but since C++17 is our minimum supported version, we can drop them now. Users can simply call the constructor for the adaptors.This PR replaces calls to
make_stream_allocator_adaptor()withstream_allocator_adaptorahead of the deprecation of these functions in RMM 24.10.